Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 23, 2025

Updates the requirements on phf to permit the latest version.

Commits
  • 03a9306 chore: Update version number
  • 4ddbefd Merge pull request #334 from rust-phf/chore/fix-test
  • ecd6a86 chore: Fix version number
  • e309f28 Release phf_shared v0.12.0, phf_generator v0.12.0, phf_macros v0.12.0, phf v0...
  • 51d6baa chore: Update changelog
  • 08e7464 chore: Update version number in docs
  • 5c3ad85 Merge pull request #333 from JohnTitor/chore/serde-no-std
  • 08897bd chore: Turn off serde std feature on no-std
  • a6df856 Merge pull request #289 from thaliaarchi/master
  • 2806801 Add support for unicase::Ascii type
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update rust code labels Jun 23, 2025
@simonwuelker
Copy link
Contributor

Why should we upgrade the minimum requirements unless necessary? html5ever is a library, it should be up to the user to decide what (compatible) phf version they want to use.

@nicoburns
Copy link
Contributor

Why should we upgrade the minimum requirements unless necessary? html5ever is a library, it should be up to the user to decide what (compatible) phf version they want to use.

0.11 and 0.12 are not compatible versions, so the user does not currently have a choice (they have to use 0.11).

I suspect that:

  • This is a breaking change
  • We should be careful to upgrade phf and phf_codegen at the same time because they need to match
  • We probably ought to upgrade
  • There's probably not a huge amount of urgency in doing so.

@nicoburns nicoburns added the V-breaking Breaking change label Jun 30, 2025
@nicoburns
Copy link
Contributor

This should also be synchronised with updating phf in the string_cache crate.

Updates the requirements on [phf](https://github.com/rust-phf/rust-phf) to permit the latest version.
- [Release notes](https://github.com/rust-phf/rust-phf/releases)
- [Changelog](https://github.com/rust-phf/rust-phf/blob/main/RELEASE_PROCESS.md)
- [Commits](rust-phf/rust-phf@phf-v0.11.1...v0.12.1)

---
updated-dependencies:
- dependency-name: phf
  dependency-version: 0.12.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/phf-0.12 branch from bfe0bd9 to d2df4c6 Compare July 2, 2025 07:53
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 25, 2025

Superseded by #659.

@dependabot dependabot bot closed this Aug 25, 2025
@dependabot dependabot bot deleted the dependabot/cargo/phf-0.12 branch August 25, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update rust code V-breaking Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants